Request 6096 (accepted)

Overview

Request 6096 (accepted)

Bump

Created by zaitor about 2 months ago
In state accepted
Package maintainer: zaitor

Submit pipewire-aptx

Submit package home:zaitor:...s:Essentials / pipewire-aptx to package Essentials / pipewire-aptx

pipewire-aptx.changes Changed

pipewire-aptx.spec Changed

pipewire-1.2.3.tar.bz2/NEWS -> pipewire-1.2.4.tar.bz2/NEWS Changed

@@ -1,3 +1,34 @@
+# PipeWire 1.2.4 (2024-09-19)
+
+This is a bugfix release that is API and ABI compatible with the
+previous 1.2.x and 1.0.x releases.
+
+## Highlights
+  - Avoid a crash in cleanup of globals. (#4250)
+  - Use systemd-logind to scan for new devices in v4l2.
+  - Some more bugfixes and improvements.
+
+
+## PipeWire
+  - Avoid a crash in cleanup of globals. (#4250)
+  - Improve RequestProcess dispatch.
+
+## Tools
+  - Improve float parsing. (#4234)
+
+## SPA
+  - Clear the ringbuffer when stopping in libcamera.
+  - Use systemd-logind to scan for new devices in v4l2. (#3539, #3960)
+  - Queue dropped first buffer in v4l2.
+  - Unlink pcm devices when moving drivers to avoid broken pipe.
+
+## JACK
+  - Emit buffer_size callback in jack_activate() to improve
+    compatibility with GStreamer. (#4260)
+
+Older versions:
+
+
 # PipeWire 1.2.3 (2024-08-22)
 
 This is a bugfix release that is API and ABI compatible with the
@@ -39,9 +70,6 @@
   - pw-cli can now handle arbitrarily large input and params. (#4166)
   - Avoid some compiler warnings in pw-top.
 
-Older versions:
-
-
 # PipeWire 1.2.2 (2024-07-31)
 
 This is a bugfix release that is API and ABI compatible with the

pipewire-1.2.3.tar.bz2/meson.build -> pipewire-1.2.4.tar.bz2/meson.build Changed

pipewire-1.2.3.tar.bz2/pipewire-jack/src/pipewire-jack.c -> pipewire-1.2.4.tar.bz2/pipewire-jack/src/pipewire-jack.c Changed

pipewire-1.2.3.tar.bz2/spa/include/spa/param/video/h264-utils.h -> pipewire-1.2.4.tar.bz2/spa/include/spa/param/video/h264-utils.h Changed

pipewire-1.2.3.tar.bz2/spa/include/spa/param/video/mjpg-utils.h -> pipewire-1.2.4.tar.bz2/spa/include/spa/param/video/mjpg-utils.h Changed

pipewire-1.2.3.tar.bz2/spa/include/spa/param/video/raw-utils.h -> pipewire-1.2.4.tar.bz2/spa/include/spa/param/video/raw-utils.h Changed

pipewire-1.2.3.tar.bz2/spa/plugins/alsa/alsa-pcm.c -> pipewire-1.2.4.tar.bz2/spa/plugins/alsa/alsa-pcm.c Changed

pipewire-1.2.3.tar.bz2/spa/plugins/audioconvert/audioadapter.c -> pipewire-1.2.4.tar.bz2/spa/plugins/audioconvert/audioadapter.c Changed

pipewire-1.2.3.tar.bz2/spa/plugins/libcamera/libcamera-utils.cpp -> pipewire-1.2.4.tar.bz2/spa/plugins/libcamera/libcamera-utils.cpp Changed

pipewire-1.2.3.tar.bz2/spa/plugins/v4l2/meson.build -> pipewire-1.2.4.tar.bz2/spa/plugins/v4l2/meson.build Changed

pipewire-1.2.3.tar.bz2/spa/plugins/v4l2/v4l2-udev.c -> pipewire-1.2.4.tar.bz2/spa/plugins/v4l2/v4l2-udev.c Changed

@@ -24,8 +24,13 @@
 #include <spa/monitor/device.h>
 #include <spa/monitor/utils.h>
 
+#include "config.h"
 #include "v4l2.h"
 
+#ifdef HAVE_SYSTEMD
+#include <systemd/sd-login.h>
+#endif
+
 #define MAX_DEVICES	64
 
 enum action {
@@ -61,6 +66,10 @@
 
 	struct spa_source source;
 	struct spa_source notify;
+#ifdef HAVE_SYSTEMD
+	struct spa_source logind;
+	sd_login_monitor *logind_monitor;
+#endif
 };
 
 static int impl_udev_open(struct impl *this)
@@ -463,6 +472,12 @@
 {
 	int notify_fd;
 
+#ifdef HAVE_SYSTEMD
+	/* Do not use inotify when using logind session monitoring */
+	if (this->logind_monitor)
+		return 0;
+#endif
+
 	if (this->notify.fd != -1)
 		return 0;
 
@@ -480,6 +495,65 @@
 	return 0;
 }
 
+#ifdef HAVE_SYSTEMD
+static void impl_on_logind_events(struct spa_source *source)
+{
+	struct impl *this = source->data;
+
+	/* Recheck access on all v4l2 devices on logind session changes */
+	for (size_t i = 0; i < this->n_devices; i++)
+		process_device(this, ACTION_CHANGE, &this->devicesi);
+
+	sd_login_monitor_flush(this->logind_monitor);
+}
+
+static int start_logind(struct impl *this)
+{
+	int res;
+
+	if (this->logind_monitor)
+		return 0;
+
+	/* If we are not actually running logind become a NOP */
+	if (access("/run/systemd/seats/", F_OK) < 0)
+		return 0;
+
+	res = sd_login_monitor_new("session", &this->logind_monitor);
+	if (res < 0)
+		return res;
+
+	spa_log_info(this->log, "start logind monitoring");
+
+	this->logind.func = impl_on_logind_events;
+	this->logind.data = this;
+	this->logind.fd = sd_login_monitor_get_fd(this->logind_monitor);
+	this->logind.mask = SPA_IO_IN | SPA_IO_ERR;
+
+	spa_loop_add_source(this->main_loop, &this->logind);
+
+	return 0;
+}
+
+static void stop_logind(struct impl *this)
+{
+	if (this->logind_monitor) {
+		spa_loop_remove_source(this->main_loop, &this->logind);
+		sd_login_monitor_unref(this->logind_monitor);
+		this->logind_monitor = NULL;
+	}
+}
+#else
+/* Stubs to avoid more ifdefs below */
+static int start_logind(struct impl *this)
+{
+	return 0;
+}
+
+static void stop_logind(struct impl *this)
+{
+}
+#endif
+
 static void impl_on_fd_events(struct spa_source *source)
 {
 	struct impl *this = source->data;
@@ -495,8 +569,6 @@
 
 	spa_log_debug(this->log, "action %s", action);
 
-	start_inotify(this);
-
 	if (spa_streq(action, "add") ||
 	    spa_streq(action, "change")) {
 		process_udev_device(this, ACTION_CHANGE, dev);
@@ -529,6 +601,9 @@
 	spa_log_debug(this->log, "monitor %p", this->umonitor);
 	spa_loop_add_source(this->main_loop, &this->source);
 
+	if ((res = start_logind(this)) < 0)
+		return res;
+
 	if ((res = start_inotify(this)) < 0)
 		return res;
 
@@ -547,6 +622,7 @@
 	this->umonitor = NULL;
 
 	stop_inotify(this);
+	stop_logind(this);
 
 	return 0;
 }
@@ -693,6 +769,9 @@
 
 	this = (struct impl *) handle;
 	this->notify.fd = -1;
+#ifdef HAVE_SYSTEMD
+	this->logind_monitor = NULL;
+#endif
 
 	this->log = spa_support_find(support, n_support, SPA_TYPE_INTERFACE_Log);
 	this->main_loop = spa_support_find(support, n_support, SPA_TYPE_INTERFACE_Loop);

pipewire-1.2.3.tar.bz2/spa/plugins/v4l2/v4l2-utils.c -> pipewire-1.2.4.tar.bz2/spa/plugins/v4l2/v4l2-utils.c Changed

pipewire-1.2.3.tar.bz2/spa/plugins/videoconvert/videoadapter.c -> pipewire-1.2.4.tar.bz2/spa/plugins/videoconvert/videoadapter.c Changed

pipewire-1.2.3.tar.bz2/src/gst/gstpipewireformat.c -> pipewire-1.2.4.tar.bz2/src/gst/gstpipewireformat.c Changed

pipewire-1.2.3.tar.bz2/src/modules/module-rtp-sap.c -> pipewire-1.2.4.tar.bz2/src/modules/module-rtp-sap.c Changed

pipewire-1.2.3.tar.bz2/src/pipewire/global.c -> pipewire-1.2.4.tar.bz2/src/pipewire/global.c Changed

pipewire-1.2.3.tar.bz2/src/pipewire/impl-node.c -> pipewire-1.2.4.tar.bz2/src/pipewire/impl-node.c Changed

pipewire-1.2.3.tar.bz2/src/tools/pw-cat.c -> pipewire-1.2.4.tar.bz2/src/tools/pw-cat.c Changed

pipewire-1.2.3.tar.bz2/src/tools/pw-loopback.c -> pipewire-1.2.4.tar.bz2/src/tools/pw-loopback.c Changed

Build Results
RPM Lint

Refresh

Comments for request 6096 0

Request History

zaitor created request about 2 months ago

Bump

zaitor accepted request about 2 months ago

Xin