olh wrote over 9 years ago

If we update anyway the spec file deserves a huge cleanup. Use pkgconfig() everywhere, just as configure.ac does (see home:olh:kodi:master). Drop unneeded buildrequires. chrpath is most likely obsolete. DATE/TIME should be patched out with patch instead of sed. Some configure options depend on others (like optimization is for included ffmpeg I think).

sagiben wrote over 9 years ago

1. do not know why it fails now, when I submitted the request all the builds passed
2. Some of the DATE/TIME can't be removed using patch because they are in a tar file.
3. I will change the the required libs to use pkgconfig
4. optimization was disabled because this version does not use internal ffmpeg

sagiben wrote over 9 years ago

How DATE/TIME can be removed using patch ? it won't get the build time as it is now

olh wrote over 9 years ago

Just drop that string, build time does not serve any purpose.

---

sagiben wrote over 9 years ago

I think it is showed in the 'System Info' tab

jsjhb wrote over 9 years ago

Please have a look at requests 1549 and 1566 to Multimedia/kodi, I fixed the occurrence, also in the tar files.

---

sagiben wrote over 9 years ago

yes, but not as a patch.

sagiben wrote over 9 years ago

OK, 1. DATE/TIME were fixed as sed commands. 2. I moved most of the BuildRequired to pkgconfig 3. chrpath was removed 4. regarding unneeded buildrequires : any easy way to check it ? I don't want to comment out each one of them and rebuild. I thought to get some of them from configure script any other suggestion ?