Packman Build Service PMBS

pipewire-aptx.changes Changed

pipewire-aptx.spec Changed

_service:download_files:pipewire-1.6.7.tar.bz2/NEWS -> _service:download_files:pipewire-1.6.8.tar.bz2/NEWS Changed

@@ -1,3 +1,46 @@
+# PipeWire 1.6.8 (2026-07-09)
+
+This is a bugfix release that is API and ABI compatible with the previous
+1.6.x releases.
+
+## Highlights
+  - Fix a data race in JACK that could cause lost MIDI events in ardour.
+  - Fix some unbounded memory allocations.
+  - Various small fixes.
+
+
+## PipeWire
+  - Avoid some graph recalcs, which fixes a bug when suspending a node
+    while it is active.
+
+## Modules
+  - Do Content-Length and allocation check in RAOP to avoid OOM errors.
+  - Fix a potential memory leak in the error path of client-node. (#5348)
+
+## SPA
+  - Fix filter-graph dynamic graph updates.
+  - Avoid 100% when unplugging a card.
+  - Fix filter-graph volumes when the filter is loaded inside a node with
+    hardware volume. (#5344)
+  - Add normalize and latency options to the SOFA filter. (#5322)
+
+## Bluetooth
+  - Fix a potential leak when transport fails to start.
+
+## Pulse-server
+  - Avoid stack exhaustion via unbounded alloca.
+
+## JACK
+  - Fix a data race in jack_port_get_buffer() when called from concurrent
+    threads, like in ardour. (#5324)
+
+## GStreamer
+  - Skip invalid crop metadata.
+  - Avoid crash because metadata listener was registered twice.
+
+
+Older versions:
+
 # PipeWire 1.6.7 (2026-06-18)
 
 This is a bugfix release that is API and ABI compatible with the previous
@@ -34,9 +77,6 @@
 ## Misc
   - Make sure we don't deal with uninitialized spa_dict.
 
-
-Older versions:
-
 # PipeWire 1.6.6 (2026-05-26)
 
 This is a bugfix release that is API and ABI compatible with the previous

_service:download_files:pipewire-1.6.7.tar.bz2/meson.build -> _service:download_files:pipewire-1.6.8.tar.bz2/meson.build Changed

_service:download_files:pipewire-1.6.7.tar.bz2/pipewire-jack/src/pipewire-jack.c -> _service:download_files:pipewire-1.6.8.tar.bz2/pipewire-jack/src/pipewire-jack.c Changed

@@ -248,6 +248,7 @@
 	struct port *peer_port;
 
 	struct spa_io_buffers *io2;
+	uint32_t io_busy;
 
 	struct spa_list queue;
 	struct buffer buffersMAX_BUFFERS;
@@ -652,6 +653,7 @@
 	mix->io0 = mix->io1 = NULL;
 	mix->n_buffers = 0;
 	spa_list_init(&mix->queue);
+	SPA_ATOMIC_STORE(mix->io_busy, 0);
 	if (mix_id == SPA_ID_INVALID) {
 		port->global_mix = mix;
 		if (port->n_mix > 0)
@@ -733,6 +735,7 @@
 	}
 	mix->n_buffers = 0;
 	spa_list_init(&mix->queue);
+	SPA_ATOMIC_STORE(mix->io_busy, 0);
 	return 0;
 }
 
@@ -1718,11 +1721,11 @@
 	if (SPA_UNLIKELY((io = mix->iocycle) == NULL || mix->n_buffers == 0))
 		return NULL;
 
-	if (io->status == SPA_STATUS_HAVE_DATA &&
+	if (SPA_ATOMIC_LOAD(io->status) == SPA_STATUS_HAVE_DATA &&
 	    io->buffer_id < mix->n_buffers) {
 		b = &mix->buffersio->buffer_id;
 		d = &b->datas0;
-	} else {
+	} else if (SPA_ATOMIC_CAS(mix->io_busy, 0, 1)) {
 		if (mix->n_buffers == 1) {
 			b = &mix->buffers0;
 		} else {
@@ -1733,6 +1736,7 @@
 			if (SPA_UNLIKELY(b == NULL)) {
 				pw_log_warn("port %p: out of buffers %d", p, mix->n_buffers);
 				io->buffer_id = SPA_ID_INVALID;
+				SPA_ATOMIC_STORE(mix->io_busy, 0);
 				return NULL;
 			}
 		}
@@ -1742,7 +1746,15 @@
 		d->chunk->stride = stride;
 
 		io->buffer_id = b->id;
-		io->status = SPA_STATUS_HAVE_DATA;
+		SPA_ATOMIC_STORE(io->status, SPA_STATUS_HAVE_DATA);
+		SPA_ATOMIC_STORE(mix->io_busy, 0);
+	} else {
+		while (SPA_ATOMIC_LOAD(io->status) != SPA_STATUS_HAVE_DATA)
+			;
+		if (SPA_UNLIKELY(io->buffer_id >= mix->n_buffers))
+			return NULL;
+		b = &mix->buffersio->buffer_id;
+		d = &b->datas0;
 	}
 	ptr = d->data;
 	if (buf)

_service:download_files:pipewire-1.6.7.tar.bz2/spa/include/spa/pod/body.h -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/include/spa/pod/body.h Changed

_service:download_files:pipewire-1.6.7.tar.bz2/spa/include/spa/utils/atomic.h -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/include/spa/utils/atomic.h Changed

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/aec/aec-webrtc.cpp -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/aec/aec-webrtc.cpp Changed

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/alsa/alsa-acp-device.c -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/alsa/alsa-acp-device.c Changed

@@ -85,17 +85,34 @@
 };
 
 static int emit_info(struct impl *this, bool full);
+static void remove_sources(struct impl *this);
 
 static void handle_acp_poll(struct spa_source *source)
 {
 	struct impl *this = source->data;
+	uint32_t rmask = 0;
 	int i;
 
-	for (i = 0; i < this->n_pfds; i++)
+	for (i = 0; i < this->n_pfds; i++) {
 		this->pfdsi.revents = this->sourcesi.rmask;
+		rmask |= this->sourcesi.rmask;
+	}
 	acp_card_handle_events(this->card);
 	for (i = 0; i < this->n_pfds; i++)
 		this->sourcesi.rmask = 0;
+
+	/* A POLLERR/POLLHUP on a poll fd (e.g. the ALSA control device was
+	 * unplugged) is level-triggered and never clears, so the loop would
+	 * redispatch this handler on every iteration and spin at 100% CPU.
+	 * Stop polling the dead descriptors; the udev monitor handles the
+	 * actual device removal, and setup_sources() re-arms on the next
+	 * profile change if the card comes back. */
+	if (rmask & (SPA_IO_ERR | SPA_IO_HUP)) {
+		spa_log_warn(this->log, "%p: poll fd error/hangup (card removed?), "
+				"removing poll sources", this);
+		remove_sources(this);
+		return;
+	}
 	emit_info(this, false);
 }

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/audioconvert/audioconvert.c -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/audioconvert/audioconvert.c Changed

@@ -1290,6 +1290,28 @@
 	return 0;
 }
 
+static int do_sync_filter_graph(struct spa_loop *loop, bool async, uint32_t seq,
+		const void *data, size_t size, void *user_data)
+{
+	struct impl *impl = user_data;
+	struct filter_graph *g;
+
+	impl->n_graph = 0;
+	spa_list_for_each(g, &impl->active_graphs, link)
+		if (g->setup && !g->removing)
+			impl->filter_graphimpl->n_graph++ = g;
+
+	impl->recalc = true;
+	return 0;
+}
+
+static void sync_filter_graph(struct impl *impl)
+{
+	if (impl->data_loop)
+		spa_loop_locked(impl->data_loop, do_sync_filter_graph, 0, NULL, 0, impl);
+	else
+		do_sync_filter_graph(NULL, false, 0, NULL, 0, impl);
+}
 
 static int setup_filter_graphs(struct impl *impl, bool force)
 {
@@ -1305,11 +1327,23 @@
 	position = in->format.info.raw.position;
 	impl->maxports = SPA_MAX(in->format.info.raw.channels, out->format.info.raw.channels);
 
+	if (force) {
+		/* A forced setup deactivates and re-instantiates each graph below,
+		 * which frees and recreates the underlying plugin handles. Pull the
+		 * graphs out of the data-loop's view first (under the loop lock, via
+		 * sync_filter_graph) so the RT thread cannot run a graph while its
+		 * handles are NULL during the rebuild. They are republished by the
+		 * sync_filter_graph() that follows setup. */
+		spa_list_for_each(g, &impl->active_graphs, link) {
+			if (!g->removing)
+				g->setup = false;
+		}
+		sync_filter_graph(impl);
+	}
+
 	spa_list_for_each_safe(g, t, &impl->active_graphs, link) {
 		if (g->removing)
 			continue;
-		if (force)
-			g->setup = false;
 		if ((res = setup_filter_graph(impl, g, channels, position)) < 0) {
 			g->removing = true;
 			spa_log_warn(impl->log, "failed to activate graph %d: %s", g->order,
@@ -1328,29 +1362,6 @@
 	return 0;
 }
 
-static int do_sync_filter_graph(struct spa_loop *loop, bool async, uint32_t seq,
-		const void *data, size_t size, void *user_data)
-{
-	struct impl *impl = user_data;
-	struct filter_graph *g;
-
-	impl->n_graph = 0;
-	spa_list_for_each(g, &impl->active_graphs, link)
-		if (g->setup && !g->removing)
-			impl->filter_graphimpl->n_graph++ = g;
-
-	impl->recalc = true;
-	return 0;
-}
-
-static void sync_filter_graph(struct impl *impl)
-{
-	if (impl->data_loop)
-		spa_loop_locked(impl->data_loop, do_sync_filter_graph, 0, NULL, 0, impl);
-	else
-		do_sync_filter_graph(NULL, false, 0, NULL, 0, impl);
-}
-
 static void clean_filter_handles(struct impl *impl, bool force)
 {
 	struct filter_graph *g, *t;

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/bluez5/bluez5-dbus.c -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/bluez5/bluez5-dbus.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/bluez5/media-sink.c -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/bluez5/media-sink.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/filter-graph/filter-graph.c -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/filter-graph/filter-graph.c Changed

@@ -760,6 +760,9 @@
 	char buf1024;
 	struct spa_pod_dynamic_builder b;
 	struct volume *vol = &graph->volumedirection;
+	float soft_volsMAX_CHANNELS;
+	uint32_t n_soft_vols = 0;
+	bool soft_mute = false, have_soft_mute = false;
 	bool do_volume = false;
 
 	spa_pod_dynamic_builder_init(&b, buf, sizeof(buf), 1024);
@@ -805,7 +808,12 @@
 			break;
 		}
 		case SPA_PROP_softVolumes:
+			n_soft_vols = spa_pod_copy_array(&prop->value, SPA_TYPE_Float, soft_vols,
+					SPA_N_ELEMENTS(soft_vols));
+			break;
 		case SPA_PROP_softMute:
+			if (spa_pod_get_bool(&prop->value, &soft_mute) == 0)
+				have_soft_mute = true;
 			break;
 		default:
 			spa_pod_builder_raw_padded(&b.b, prop, SPA_POD_PROP_SIZE(prop));
@@ -813,24 +821,27 @@
 		}
 	}
 	if (do_volume && vol->n_ports != 0) {
-		float soft_volsMAX_CHANNELS;
 		uint32_t i;
 
 		for (i = 0; i < vol->n_volumes; i++)
 			soft_volsi = (vol->mute || vol->volumesi == 0.0f) ? 0.0f : 1.0f;
+		n_soft_vols = vol->n_volumes;
+		soft_mute = vol->mute;
+		have_soft_mute = true;
 
+		sync_volume(graph, vol);
+	}
+	if (have_soft_mute) {
 		spa_pod_builder_prop(&b.b, SPA_PROP_softMute, 0);
-		spa_pod_builder_bool(&b.b, vol->mute);
+		spa_pod_builder_bool(&b.b, soft_mute);
+	}
+	if (n_soft_vols > 0) {
 		spa_pod_builder_prop(&b.b, SPA_PROP_softVolumes, 0);
 		spa_pod_builder_array(&b.b, sizeof(float), SPA_TYPE_Float,
-				vol->n_volumes, soft_vols);
-		props = spa_pod_builder_pop(&b.b, &f0);
-
-		sync_volume(graph, vol);
-
-	} else {
-		props = spa_pod_builder_pop(&b.b, &f0);
+				n_soft_vols, soft_vols);
 	}
+	props = spa_pod_builder_pop(&b.b, &f0);
+
 	spa_filter_graph_emit_apply_props(&impl->hooks, direction, props);
 
 	spa_pod_dynamic_builder_clean(&b);

_service:download_files:pipewire-1.6.7.tar.bz2/spa/plugins/filter-graph/plugin_sofa.c -> _service:download_files:pipewire-1.6.8.tar.bz2/spa/plugins/filter-graph/plugin_sofa.c Changed

@@ -34,6 +34,7 @@
 	int n_samples, blocksize, tailsize;
 	float gain;
 	float *tmp2;
+	float latency;
 
 	struct MYSOFA_EASY *sofa;
 	unsigned int interpolate:1;
@@ -50,6 +51,8 @@
 	const char *val;
 	char key256;
 	char filenamePATH_MAX = "";
+	bool normalize = false;
+	float normalized;
 	int len;
 
 	errno = EINVAL;
@@ -73,6 +76,7 @@
 	impl->dsp = pl->dsp;
 	impl->log = pl->log;
 	impl->gain = 1.0f;
+	impl->latency = 0.0f;
 
 	while ((len = spa_json_object_next(&it0, key, sizeof(key), &val)) > 0) {
 		if (spa_streq(key, "blocksize")) {
@@ -103,6 +107,23 @@
 				goto error;
 			}
 		}
+		else if (spa_streq(key, "normalize")) {
+			if (spa_json_parse_bool(val, len, &normalize) <= 0) {
+				spa_log_error(impl->log, "spatializer:normalize requires a bool");
+				errno = EINVAL;
+				goto error;
+			}
+		}
+		else if (spa_streq(key, "latency")) {
+			if (spa_json_parse_float(val, len, &impl->latency) <= 0) {
+				spa_log_error(impl->log, "spatializer:latency requires a number");
+				errno = EINVAL;
+				goto error;
+			}
+		}
+		else {
+			spa_log_warn(pl->log, "spatializer: ignoring config key: '%s'", key);
+		}
 	}
 	if (!filename0) {
 		spa_log_error(impl->log, "spatializer:filename was not given");
@@ -195,8 +216,13 @@
 	if (impl->tailsize <= 0)
 		impl->tailsize = SPA_CLAMP(4096, impl->blocksize, 32768);
 
-	spa_log_info(impl->log, "using n_samples:%u %d:%d blocksize gain:%f sofa:%s", impl->n_samples,
-		impl->blocksize, impl->tailsize, impl->gain, filename);
+	if (normalize)
+		normalized = mysofa_loudness(impl->sofa->hrtf);
+
+	spa_log_info(impl->log, "using n_samples:%u %d:%d blocksize %sgain:%f sofa:%s", impl->n_samples,
+		impl->blocksize, impl->tailsize,
+		normalize ? "auto" : "", normalize ? normalized : impl->gain, filename);
+
 
 	impl->tmp0 = calloc(impl->plugin->quantum_limit, sizeof(float));
 	impl->tmp1 = calloc(impl->plugin->quantum_limit, sizeof(float));
@@ -331,7 +357,7 @@
 		convolver_run(impl->l_conv0, impl->port2, impl->port0, SampleCount);
 		convolver_run(impl->r_conv0, impl->port2, impl->port1, SampleCount);
 	}
-	impl->port60 = impl->n_samples;
+	impl->port60 = impl->latency;
 }
 
 static void spatializer_connect_port(void * Instance, unsigned long Port,
@@ -367,7 +393,7 @@
 static void spatializer_activate(void * Instance)
 {
 	struct spatializer_impl *impl = Instance;
-	impl->port60 = impl->n_samples;
+	impl->port60 = impl->latency;
 }
 
 static void spatializer_deactivate(void * Instance)

_service:download_files:pipewire-1.6.7.tar.bz2/src/gst/gstpipewiredeviceprovider.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/gst/gstpipewiredeviceprovider.c Changed

@@ -729,8 +729,16 @@
     if (!spa_streq(name, "default"))
       return;
 
+    /* PipeWire re-emits the global event for the same id when the client's
+     * permissions change. Only bind and add the listener once, otherwise we
+     * would re-append the already-linked metadata_listener hook and corrupt
+     * the proxy's listener list. */
+    if (self->metadata != NULL)
+      return;
+
     self->metadata =
         pw_registry_bind(self->registry, id, type, PW_VERSION_METADATA, 0);
+    self->metadata_id = id;
     pw_metadata_add_listener(self->metadata, &self->metadata_listener,
                              &metadata_events, self);
   }
@@ -744,6 +752,13 @@
 
 static void registry_event_global_remove(void *data, uint32_t id)
 {
+  GstPipeWireDeviceProvider *self = data;
+
+  if (self->metadata != NULL && self->metadata_id == id) {
+    spa_hook_remove(&self->metadata_listener);
+    pw_proxy_destroy((struct pw_proxy *)self->metadata);
+    self->metadata = NULL;
+  }
 }
 
 static const struct pw_registry_events registry_events = {

_service:download_files:pipewire-1.6.7.tar.bz2/src/gst/gstpipewiredeviceprovider.h -> _service:download_files:pipewire-1.6.8.tar.bz2/src/gst/gstpipewiredeviceprovider.h Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/gst/gstpipewiresrc.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/gst/gstpipewiresrc.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/modules/module-client-node/remote-node.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/modules/module-client-node/remote-node.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/modules/module-filter-chain.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/modules/module-filter-chain.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/modules/module-protocol-pulse/pulse-server.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/modules/module-protocol-pulse/pulse-server.c Changed

@@ -71,6 +71,7 @@
 /* The max amount of data we send in one block when capturing. In PulseAudio this
  * size is derived from the mempool PA_MEMPOOL_SLOT_SIZE */
 #define MAX_BLOCK	(64*1024)
+#define MAX_ALLOCA_SIZE	(64*1024)
 
 #define TEMPORARY_MOVE_TIMEOUT	(SPA_NSEC_PER_SEC)
 
@@ -3173,6 +3174,8 @@
 		return -ENOENT;
 
 	collect_card_info(card, &card_info);
+	if (card_info.n_ports > MAX_ALLOCA_SIZE / sizeof(*port_info))
+		return -ENOMEM;
 	port_info = alloca(card_info.n_ports * sizeof(*port_info));
 	card_info.active_profile = SPA_ID_INVALID;
 	n_ports = collect_port_info(card, &card_info, NULL, port_info);
@@ -3314,6 +3317,8 @@
 	}
 
 	dict.n_items = props->dict.n_items;
+	if (dict.n_items > MAX_ALLOCA_SIZE / sizeof(struct spa_dict_item))
+		return -ENOMEM;
 	dict.items = items = alloca(sizeof(struct spa_dict_item) * dict.n_items);
 	for (i = 0; i < dict.n_items; i++) {
 		itemsi.key = props->dict.itemsi.key;
@@ -3597,6 +3602,8 @@
 		TAG_U32, card_info.n_profiles,			/* n_profiles */
 		TAG_INVALID);
 
+	if (card_info.n_profiles > MAX_ALLOCA_SIZE / sizeof(*profile_info))
+		return -ENOMEM;
 	profile_info = alloca(card_info.n_profiles * sizeof(*profile_info));
 	n_profiles = collect_profile_info(o, &card_info, profile_info);
 
@@ -3626,6 +3633,8 @@
 		uint32_t n_ports;
 		struct port_info *port_info, *pi;
 
+		if (card_info.n_ports > MAX_ALLOCA_SIZE / sizeof(*port_info))
+			return -ENOMEM;
 		port_info = alloca(card_info.n_ports * sizeof(*port_info));
 		card_info.active_profile = SPA_ID_INVALID;
 		n_ports = collect_port_info(o, &card_info, NULL, port_info);
@@ -3641,7 +3650,8 @@
 
 			pi = &port_infon;
 
-			if (pi->info && pi->n_props > 0) {
+			if (pi->info && pi->n_props > 0 &&
+			    pi->n_props <= MAX_ALLOCA_SIZE / sizeof(*items)) {
 				items = alloca(pi->n_props * sizeof(*items));
 				pdict = collect_props(pi->info, &dict, items, pi->n_props);
 			}
@@ -3829,6 +3839,8 @@
 		uint32_t n_ports, n;
 		struct port_info *port_info, *pi;
 
+		if (card_info.n_ports > MAX_ALLOCA_SIZE / sizeof(*port_info))
+			return -ENOMEM;
 		port_info = alloca(card_info.n_ports * sizeof(*port_info));
 		n_ports = collect_port_info(card, &card_info, &dev_info, port_info);
 
@@ -4025,6 +4037,8 @@
 		uint32_t n_ports, n;
 		struct port_info *port_info, *pi;
 
+		if (card_info.n_ports > MAX_ALLOCA_SIZE / sizeof(*port_info))
+			return -ENOMEM;
 		port_info = alloca(card_info.n_ports * sizeof(*port_info));
 		n_ports = collect_port_info(card, &card_info, &dev_info, port_info);

_service:download_files:pipewire-1.6.7.tar.bz2/src/modules/module-raop/rtsp-client.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/modules/module-raop/rtsp-client.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/modules/module-rtp/stream.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/modules/module-rtp/stream.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/pipewire/context.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/pipewire/context.c Changed

@@ -58,7 +58,7 @@
 	struct pw_context this;
 	struct spa_handle *dbus_handle;
 	struct spa_plugin_loader plugin_loader;
-	unsigned int recalc:1;
+	int recalc;
 	unsigned int recalc_pending:1;
 
 	uint32_t cpu_count;
@@ -1445,13 +1445,13 @@
 
 	pw_log_info("%p: busy:%d reason:%s", context, impl->recalc, reason);
 
-	if (impl->recalc) {
+	if (impl->recalc > 0) {
 		impl->recalc_pending = true;
 		return -EBUSY;
 	}
 
 again:
-	impl->recalc = true;
+	impl->recalc++;
 	freewheel = false;
 
 	/* clean up the flags first */
@@ -1775,6 +1775,7 @@
 			if (do_reconfigure) {
 				reconfigure_driver(context, n);
 				/* we might be suspended now and the links need to be prepared again */
+				impl->recalc--;
 				goto again;
 			}
 			/* we have a pending change. We place the new values in the
@@ -1832,8 +1833,7 @@
 		/* now that all the followers are ready, start the driver */
 		ensure_state(n, running);
 	}
-	impl->recalc = false;
-	if (impl->recalc_pending) {
+	if (--impl->recalc == 0 && impl->recalc_pending) {
 		impl->recalc_pending = false;
 		goto again;
 	}
@@ -1841,6 +1841,23 @@
 	return 0;
 }
 
+int pw_context_freeze_recalc_graph(struct pw_context *context)
+{
+	struct impl *impl = SPA_CONTAINER_OF(context, struct impl, this);
+	impl->recalc++;
+	return 0;
+}
+
+int pw_context_thaw_recalc_graph(struct pw_context *context, const char *reason)
+{
+	struct impl *impl = SPA_CONTAINER_OF(context, struct impl, this);
+	if (--impl->recalc == 0 && impl->recalc_pending) {
+		impl->recalc_pending = false;
+		pw_context_recalc_graph(context, reason);
+	}
+	return 0;
+}
+
 SPA_EXPORT
 int pw_context_add_spa_lib(struct pw_context *context,
 		const char *factory_regexp, const char *lib)

_service:download_files:pipewire-1.6.7.tar.bz2/src/pipewire/impl-node.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/pipewire/impl-node.c Changed

@@ -286,6 +286,8 @@
 	/* make sure the node doesn't get woken up while not active */
 	remove_node_from_graph(this);
 
+	pw_context_freeze_recalc_graph(this->context);
+
 	spa_list_for_each(port, &this->input_ports, link) {
 		spa_list_for_each(link, &port->links, input_link)
 			pw_impl_link_deactivate(link);
@@ -294,6 +296,7 @@
 		spa_list_for_each(link, &port->links, output_link)
 			pw_impl_link_deactivate(link);
 	}
+	pw_context_thaw_recalc_graph(this->context, "node deactivate");
 }
 
 static int idle_node(struct pw_impl_node *this)
@@ -327,6 +330,8 @@
 	struct pw_impl_port *port;
 
 	pw_log_debug("%p: activate", this);
+	pw_context_freeze_recalc_graph(this->context);
+
 	spa_list_for_each(port, &this->output_ports, link) {
 		struct pw_impl_link *link;
 		spa_list_for_each(link, &port->links, output_link)
@@ -337,6 +342,7 @@
 		spa_list_for_each(link, &port->links, input_link)
 			pw_impl_link_activate(link);
 	}
+	pw_context_thaw_recalc_graph(this->context, "node activate");
 }
 
 static int start_node(struct pw_impl_node *this)
@@ -537,6 +543,8 @@
 	if (this->info.state > 0 && this->info.state <= PW_NODE_STATE_SUSPENDED)
 		return 0;
 
+	pw_context_freeze_recalc_graph(this->context);
+
 	node_deactivate(this);
 
 	pw_log_debug("%p: suspend node driving:%d driver:%d prepared:%d", this,
@@ -555,6 +563,8 @@
 	spa_list_for_each(p, &this->output_ports, link)
 		pw_impl_port_suspend(p);
 
+	pw_context_thaw_recalc_graph(this->context, "node suspend");
+
 	node_update_state(this, PW_NODE_STATE_SUSPENDED, 0, NULL);
 
 	return res;
@@ -2399,6 +2409,8 @@
 	pw_log_debug("%p: destroy", impl);
 	pw_log_info("(%s-%u) destroy", node->name, node->info.id);
 
+	pw_context_freeze_recalc_graph(context);
+
 	node_deactivate(node);
 
 	suspend_node(node);
@@ -2440,11 +2452,12 @@
 		spa_hook_remove(&node->global_listener);
 		pw_global_destroy(node->global);
 	}
-
 	if (active || had_driver)
 		pw_context_recalc_graph(context,
 				"active node destroy");
 
+	pw_context_thaw_recalc_graph(context, "node destroy");
+
 	pw_log_debug("%p: free", node);
 	pw_impl_node_emit_free(node);

_service:download_files:pipewire-1.6.7.tar.bz2/src/pipewire/impl-port.c -> _service:download_files:pipewire-1.6.8.tar.bz2/src/pipewire/impl-port.c Changed

_service:download_files:pipewire-1.6.7.tar.bz2/src/pipewire/private.h -> _service:download_files:pipewire-1.6.8.tar.bz2/src/pipewire/private.h Changed

Changes of Revision 69